[U-Boot] [PATCH 06/13] rockchip: rk3066: add core support

[Simon Glass]

Hi Pawel,

On 15 June 2017 at 09:41, Paweł Jarosz <paweljarosz3691 at gmail.com> wrote:
> Hi
>
>
> W dniu 15.06.2017 o 16:57, Simon Glass pisze:
>
>> +Philipp
>>
>> Hi Kever,
>>
>> On 14 June 2017 at 06:15, Kever Yang <kever.yang at rock-chips.com> wrote:
>>>
>>> Simon,
>>>
>>>
>>>
>>> On 06/13/2017 07:50 AM, Simon Glass wrote:
>>>>
>>>> Hi Pawel,
>>>>
>>>> On 9 June 2017 at 07:03, Paweł Jarosz <paweljarosz3691 at gmail.com> wrote:
>>>>>
>>>>>
>>>>> W dniu 09.06.2017 o 14:27, Simon Glass pisze:
>>>>>
>>>>>> Hi Pawel,
>>>>>>
>>>>>> On 7 June 2017 at 09:22, Paweł Jarosz <paweljarosz3691 at gmail.com>
>>>>>> wrote:
>>>>>>>
>>>>>>> Hi Simon
>>>>>>>
>>>>>>>
>>>>>>> W dniu 06.06.2017 o 23:10, Simon Glass pisze:
>>>>>>>>
>>>>>>>> Hi Pawel,
>>>>>>>>
>>>>>>>> On 6 June 2017 at 12:50, Paweł Jarosz <paweljarosz3691 at gmail.com>
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> +#include <dm/test.h>
>>>>>>>>> +#include <dm/util.h>
>>>>>>>>> +#include <power/regulator.h>
>>>>>>>>> +#include <syscon.h>
>>>>>>>>
>>>>>>>> That should go below spi.h
>>>>>>>>
>>>>>>> Ok
>>>>>>>>>
>>>>>>>>> +
>>>>>>>>> +DECLARE_GLOBAL_DATA_PTR;
>>>>>>>>> +
>>>>>>>>> +u32 spl_boot_device(void)
>>>>>>>>> +{
>>>>>>>>
>>>>>>>> This function seems to be common. Can you please (in a separate
>>>>>>>> patch)
>>>>>>>> move it into a separate shared file and delete all the copies?
>>>>>>>
>>>>>>> Ok
>>>>>>>>
>>>>>>>>
>>>>>>>>> +
>>>>>>>>> +       sdram_initialise();
>>>>>>>>
>>>>>>>> How come TPL is setting up the DRAM? Shouldn't that be done in SPL?
>>>>>>>>
>>>>>>> Due to size issues i needed to move spl load to sdram (not sram) and
>>>>>>> sdram
>>>>>>> settings
>>>>>>> should be done by code executed in SRAM or you get to hang a board.
>>>>>>
>>>>>> What is the size limit on SRAM?
>>>>>
>>>>>
>>>>> RK3066 has 64KB SRAM but bootrom only reads 1KB + 31KB.
>>>>
>>>> That is not a very low limit. RK3288 uses SPL (and not TPL) and it has
>>>> the same limit. Can we not just drop the use of TPL?
>>>
>>>
>>> I don't think rk3066 can drop TPL, because the bootrom for rk3066 is
>>> very much like rk3188:
>>> - bootrom read 1KB and run it, in purpose of get higher frequency;
>>> - back to bootrom;
>>> - bootrom continue read 31KB most and run it;
>>> - back to bootrom if needed;
>>> - boot rom read and run loader like uboot.
>>
>> OK then it sounds like we will need TPL. Is that right Pawel?
>>
>
> We don't need tpl if i use early back to bootrom in start.S patch with
> spl... but i didn't test it yet. If it will work i will drop the tpl. Is
> that ok?

It's OK with me. I don't know how the BROM re-enters SPL after the
first call into the 1KB region. Depending on how that works, it might
be too painful to use SPL only (e.g. if it jumps to a place in the
middle of SPL).

Regards,
Simon