[U-Boot] [PATCH v2 01/13] drivers: usb: dwc3: remove devm_zalloc from linux_compact

Marek Vasut marex at denx.de
Thu Jun 15 16:55:42 UTC 2017


On 06/14/2017 11:05 AM, Vignesh R wrote:
> 
> 
> On Tuesday 13 June 2017 07:28 PM, Marek Vasut wrote:
>> On 06/13/2017 02:09 PM, Vignesh R wrote:
>>> From: Mugunthan V N <mugunthanvnm at ti.com>
>>>
>>> devm_zalloc() is already defined in dm/device.h header, so
>>> devm_zalloc can be removed from linux_compact.h beader file.
>>
>> Shouldn't it be left in linux_compat.h instead ?
> 
> linux-compat.h is local to dwc3 folder where as dm/device.h is available
> globally. My understanding is linux-compat.h is to define
> functions/wrappers needed by dwc3 part picked from linux that are not
> yet directly available in U-Boot. But, given that devm_kzalloc() is
> provided in U-Boot, I thought it would be better to get rid of
> definition in linux-compat.h in order to avoid conflicting definition error.

OK, I see . That seems fine then.

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list