[U-Boot] [PATCH v7 03/10] clk: add clk_disable_all()

[Lothar Waßmann]

Hi,

On Tue, 20 Jun 2017 11:59:04 +0200 patrice.chotard at st.com wrote:
> From: Patrice Chotard <patrice.chotard at st.com>
> 
> Add clk_disable_all() method which Request/Disable/Free an
> array of clocks that has been previously requested by
> clk_request/get_by_*()
> 
> Signed-off-by: Patrice Chotard <patrice.chotard at st.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> ---
> 
> v7:	_ none
> v6:	_ none
> v5:	_ none
> v4:	_ none
> v3:	_ add commit message
> v2:	_ create this independant path for printf() replacement
> 
>  drivers/clk/clk-uclass.c | 22 ++++++++++++++++++++++
>  include/clk.h            | 10 ++++++++++
>  2 files changed, 32 insertions(+)
> 
> diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c
> index 83b6328..e732514 100644
> --- a/drivers/clk/clk-uclass.c
> +++ b/drivers/clk/clk-uclass.c
> @@ -187,6 +187,28 @@ int clk_disable(struct clk *clk)
>  	return ops->disable(clk);
>  }
>  
> +int clk_disable_all(struct clk *clk, int count)
> +{
> +	int i, ret;
> +
> +	debug("%s(clk=%p count=%d)\n", __func__, clk, count);
> +
> +	for (i = 0; i < count; i++) {
> +		ret = clk_request(clk->dev, &clk[i]);
>
Shouldn't this be:
		ret = clk_request(clk[i].dev, &clk[i]);



Lothar Waßmann