[U-Boot] Initilize IDE prior environment

[Tom Rini]

On Mon, Jun 19, 2017 at 11:56:04AM -0300, Otavio Salvador wrote:

> To allow the loading of environment from IDE (for example, using FAT)
> the initilization of IDE subsystem must come before the environment
> one.
> 
> Successfully tested on QEMU x86.
> 
> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
> ---
> 
>  common/board_r.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/common/board_r.c b/common/board_r.c
> index adc1f1937e..247a6668fc 100644
> --- a/common/board_r.c
> +++ b/common/board_r.c
> @@ -806,6 +806,9 @@ static init_fnc_t init_sequence_r[] = {
>  #ifdef CONFIG_MMC
>  	initr_mmc,
>  #endif
> +#if defined(CONFIG_IDE)
> +	initr_ide,
> +#endif
>  #ifdef CONFIG_HAS_DATAFLASH
>  	initr_dataflash,
>  #endif
> @@ -878,9 +881,6 @@ static init_fnc_t init_sequence_r[] = {
>  #if defined(CONFIG_CMD_PCMCIA) && !defined(CONFIG_IDE)
>  	initr_pcmcia,
>  #endif
> -#if defined(CONFIG_IDE)
> -	initr_ide,
> -#endif
>  #ifdef CONFIG_LAST_STAGE_INIT
>  	INIT_FUNC_WATCHDOG_RESET
>  	/*

Looking at the gap between these two areas, I see that we would
initialize PCI between the two areas.  So there's probably boards with
PCI IDE devices that'll regress if I take this now.  What's the answer?
Long term, device model.  Short term?  Is there a specific upstream
platform that you're seeing the problem or, or just custom / out of
tree?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170620/d7b14a5c/attachment.sig>