[U-Boot] [PATCH 11/11] powerpc, 8xx: Add a directory for soon to come boards from CSSI

[Tom Rini]

On Wed, Jun 21, 2017 at 05:51:35PM +0200, Heiko Schocher wrote:
> Hello Christophe,
> 
> Am 21.06.2017 um 17:22 schrieb Tom Rini:
> >On Wed, Jun 21, 2017 at 05:09:09PM +0200, Christophe Leroy wrote:
> >
> >>CS Systemes d'Information (CSSI) manufactures two boards, named MCR3000
> >>and CMPC885 which are respectively based on MPC866 and MPC885.
> >>This patch is the skeleton to allow soon inclusion of support for
> >>those two boards.
> >>
> >>Signed-off-by: Christophe Leroy <christophe.leroy at c-s.fr>
> >>---
> >>  The source code for those two boards needs consequent cleanup
> >>before being suitable for inclusion, however we need to stop
> >>8xx deletion hemoragia as soon as possible.
> >
> >With what I'm going to send out as a v2 of the rest of the series, I'm
> >OK with not including an empty directory for now and bringing back
> >mpc8xx, thanks again!
> 
> Hmm.. do we really want back the old files?

Yes, we do.  Revert, and then improve.  We will not let mpc8xx fall
behind, but we need to bring things back to start with.

> Just a fast look in the patchstatistic:
> 
>  arch/powerpc/cpu/mpc8xx/spi.c          |  533 ++++++++++++
> 
> No, spi drivers are in drivers/spi nowadays
> 
>  arch/powerpc/cpu/mpc8xx/scc.c          |  472 +++++++++++
>  arch/powerpc/cpu/mpc8xx/fec.c          |  933 +++++++++++++++++++++
>  arch/powerpc/cpu/mpc8xx/fec.h          |   12 +
> 
> -> driver/net
> 
>  arch/powerpc/cpu/mpc8xx/serial.c       |  676 ++++++++++++++++
> 
> -> drivers/serial
> 
> Only fast look into:
> arch/powerpc/cpu/mpc8xx/spi.c
> 
>         cp->cp_pbpar |=  0x0000000E;    /* set  bits    */
> 
> No use of ioaccesors, no defines for magic values ...:-(
> 
> DM support? Cleanup for Kconfig support?
> 
> One reason of the remove was, that the mpc8xx files wasn;t in a good
> shape, and nobody volunteered for cleaning it up ...
> 
> Are there plans to clean this up ?
> 
> If no: NACK from me, sorry.

Yes, agreed, DM conversion, Kconfig work, and otherwise cleaning things
up to be as clean as newer architecture work is, is required to keep
mpc8xx in.

> Why not posting a patchset, which introduce mpc8xx support only?

This, fwiw, is what I sent out as v2, but needs to be v3'd.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170621/69803ba9/attachment.sig>