[U-Boot] [PATCH 05/16] usb: hub: Add a new API to test if a hub device is root hub

[Bin Meng]

Hi Marek,

On Sat, Jun 24, 2017 at 1:57 AM, Marek Vasut <marex at denx.de> wrote:
> On 06/23/2017 11:54 AM, Bin Meng wrote:
>> Sometimes we need know if a given hub device is root hub or not.
>> Add a new API to test this.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> ---
>>
>>  common/usb_hub.c | 10 ++++++++++
>>  include/usb.h    |  8 ++++++++
>>  2 files changed, 18 insertions(+)
>>
>> diff --git a/common/usb_hub.c b/common/usb_hub.c
>> index 18bd827..d780251 100644
>> --- a/common/usb_hub.c
>> +++ b/common/usb_hub.c
>> @@ -74,6 +74,16 @@ static inline bool usb_hub_is_superspeed(struct usb_device *hdev)
>>       return hdev->descriptor.bDeviceProtocol == 3;
>>  }
>>
>> +#ifdef CONFIG_DM_USB
>> +bool usb_hub_is_root_hub(struct udevice *hub)
>
> Actually , this is the is_root_hub() from the 6/16 , right , not a new
> API. If you want to factor out stuff , just do that , but also remove
> the is_root_hub() and do the conversion in the same patch.
>

Correct, is_root_hub() is static within xhci.c and only used by part
of the xHCI driver. To other USB codes, this is a new API. The two
patches (5/16, 6/16) are still self-contained, as each is against a
single module. But if you would like to do the two in one patch, let
me know and I will do in v2.

[snip]

Regards,
Bin