[U-Boot] [RFC 1/1] omap3: incorrect logical check in do_emif4_init - Please, pull.

[Tom Rini]

On Sun, Jun 25, 2017 at 08:13:19AM +0200, Heinrich Schuchardt wrote:

> Hello Tom,
> 
> could you, please, pull the patch
> https://patchwork.ozlabs.org/patch/751043/
> which has been reviewed in April.

I actually want to run-test this patch.  I happen to have a platform,
and I even set it up the other day, but forgot about this patch.  I'll
set it back up and test it, then apply.  Thanks!

> 
> Best regards
> 
> Heinrich Schuchardt
> 
> On 04/16/2017 09:34 PM, Simon Glass wrote:
> > On 15 April 2017 at 08:11, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> >> ((readl(&emif4_base->sdram_iodft_tlgc) & (1<<10)) == 0x01)
> >> is always false.
> >> This does not match the comment
> >> /*Wait till that bit clears*/
> >>
> >> The problem was indicated by cppcheck.
> >>
> >> I do not have the hardware to test if the code change below
> >> leads to a correct system behavior.
> >>
> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> >> ---
> >>  arch/arm/mach-omap2/omap3/emif4.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> > 
> 

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170625/2ba95f19/attachment.sig>