[U-Boot] [PATCH] arch: armv8: Remove the error when dcache is off

Alexander Graf agraf at suse.de
Tue Jun 27 11:01:00 UTC 2017


I don't think that's going to work - at least not without compiler flag 
changes. By default, gcc will happily generate unaligned accesses. If 
you disable dcache, these will trap.

Alex

On 27.06.17 11:04, Michal Simek wrote:
> Hi guys,
> 
> do you have any concern about this change?
> 
> Thanks,
> Michal
> 
> On 22.6.2017 12:00, Siva Durga Prasad Paladugu wrote:
>> Remove the error which causes compilation failure when
>> dcache is off for builds otherthan SPL. There may be
>> cases where user wants to disable dcache completely
>> eventhough it is not SPL.
>>
>> Signed-off-by: Siva Durga Prasad Paladugu <sivadur at xilinx.com>
>> ---
>>   arch/arm/cpu/armv8/cache_v8.c | 9 ---------
>>   1 file changed, 9 deletions(-)
>>
>> diff --git a/arch/arm/cpu/armv8/cache_v8.c b/arch/arm/cpu/armv8/cache_v8.c
>> index adc7e17..d11efcc 100644
>> --- a/arch/arm/cpu/armv8/cache_v8.c
>> +++ b/arch/arm/cpu/armv8/cache_v8.c
>> @@ -647,15 +647,6 @@ void mmu_change_region_attr(phys_addr_t addr, size_t siz, u64 attrs)
>>   
>>   #else	/* CONFIG_SYS_DCACHE_OFF */
>>   
>> -/*
>> - * For SPL builds, we may want to not have dcache enabled. Any real U-Boot
>> - * running however really wants to have dcache and the MMU active. Check that
>> - * everything is sane and give the developer a hint if it isn't.
>> - */
>> -#ifndef CONFIG_SPL_BUILD
>> -#error Please describe your MMU layout in CONFIG_SYS_MEM_MAP and enable dcache.
>> -#endif
>> -
>>   void invalidate_dcache_all(void)
>>   {
>>   }
>>
> 


More information about the U-Boot mailing list