[U-Boot] wrong location of CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT in cpu-dt.c for armv8

[Chevalier, Bruno (EXT - BE/Antwerp)]

Hi,

We are doing some quick prototyping and noticing some issues.
Look at the latest changeset ( http://git.denx.de/?p=u-boot.git;a=commit;h=026f30ec3e846edb85b5df8265d8cad098184be6 ) that changed arch/arm/cpu/armv8/cpu-dt.c 

We can find the diff here:
http://git.denx.de/?p=u-boot.git;a=blobdiff;f=arch/arm/cpu/armv8/cpu-dt.c;h=e3c8aa2e6131b9af7d51333152bb119ba837a3a4;hp=5156a15d110cbc2b10d65f7e3acd0bf2928b813c;hb=026f30ec3e846edb85b5df8265d8cad098184be6;hpb=d14428c729fb620da73234f5a8862066454de44c

For some reason
#ifdef CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT

Was moved to the line before the start of the definition of psci_update_dt(void *fdt).
Our prototyping board uses PSCI, but we currently do not make use of CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT.

>From the changeset's commit message:
PSCI can be used on both multiple and single core socs. Current
implementation only allows PSCI to work on multiple core socs.
This patch removes this restriction so that PSCI can work on
single core socs as well.

Can somebody explain to me why the function definition of psci_update_dt is removed when CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT is not defined?

According to me, the only thing that should have been removed (based on the commit message) is #ifdef CONFIG_MP .


Kind regards,
Bruno Chevalier