[U-Boot] [PATCH 1/1] Set VLD04 output to 2.8V in PMIC initialization.

Fabio Estevam festevam at gmail.com
Wed Jun 28 14:13:19 UTC 2017


Hi Gautam,

On Tue, Jun 27, 2017 at 11:32 PM, mind entropy <mindentropy at gmail.com> wrote:

> Hi Fabio,
>
> The patch for the kernel was supposed to be next. Should I send the kernel
> patch to mainline or some place else?

Do you have MIPI DSI working in mainline kernel? If you do, please
share the patches.

You can use ./scripts/get_maintainer.pl to get the people and lists to
put on Cc.

> Coming to u-boot, the fact that even if there is no MIPI DSI/MIPI CSI
> support the voltage would still be 3.3V in those rails. In my case I do not
> attach the display after u-boot boots up. I keep the display attached and
> sometimes I leave it in u-boot command line without going over to the
> kernel. Since this is a development board this is often the case for many
> developers and there may be chances of the display getting damaged.

It makes sense now. Please send a v2 with the following changes:

1.  Add mx7dsabresd to the Subject, so that it becomes: mx7dsabresd:
Set VLD04 output to 2.8V

2. Explain in the commit message why you are doing such change, just
like you did above, where you explain that the default LDO4 output is
3.3V and that is beyond the MIPI DSI spec.

3. Remove the extra parentesis (0xF): regval &= ~0xF; is enough.

Thanks


More information about the U-Boot mailing list