[U-Boot] [PATCH] mmc: cadence: use fdt32_t for DT property value to fix sparse warning
Jaehoon Chung
jh80.chung at samsung.com
Thu Jun 29 09:46:11 UTC 2017
On 06/22/2017 05:58 PM, Masahiro Yamada wrote:
> DTB is encoded in big endian. When we retrieve property values,
> we need to use fdt32_to_cpu (aka be32_to_cpu) for endian conversion.
> This is a bit error-prone, but sparse is useful to detect endian
> mismatch.
>
> We need to use (fdt32_t *) instead of (u32 *) for a pointer of a
> property value. Otherwise sparse warns "cast to restricted __be32".
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
Applied to u-boot-mmc. Thanks!
Best Regards,
Jaehoon Chung
> ---
>
> drivers/mmc/sdhci-cadence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/sdhci-cadence.c b/drivers/mmc/sdhci-cadence.c
> index 4bd2623eaef9..f83c1d724108 100644
> --- a/drivers/mmc/sdhci-cadence.c
> +++ b/drivers/mmc/sdhci-cadence.c
> @@ -92,7 +92,7 @@ static int sdhci_cdns_write_phy_reg(struct sdhci_cdns_plat *plat,
> static int sdhci_cdns_phy_init(struct sdhci_cdns_plat *plat,
> const void *fdt, int nodeoffset)
> {
> - const u32 *prop;
> + const fdt32_t *prop;
> int ret, i;
>
> for (i = 0; i < ARRAY_SIZE(sdhci_cdns_phy_cfgs); i++) {
>
More information about the U-Boot
mailing list