[U-Boot] [PATCH v2 2/2] regulator: lp873x: Fix the return value of ldo/buck_get_enable function

Keerthy j-keerthy at ti.com
Thu Jun 29 09:59:27 UTC 2017



On Thursday 29 June 2017 03:10 PM, Jaehoon Chung wrote:
> On 06/12/2017 11:36 PM, Keerthy wrote:
>> The functions wrongly returned an integer while it is supposed to
>> return boolean. Fix that.
>>
>> Fixes: 99785de83 ("power: regulator: lp873x: Add regulator support")
>> Signed-off-by: Keerthy <j-keerthy at ti.com>
> 
> Applied to u-boot-mmc for pmic. Thanks!

Jaehoon,

Oops! This is not needed as per latest discussion here:
https://www.mail-archive.com/u-boot@lists.denx.de/msg253113.html

Regards,
Keerthy

> 
> Best Regards,
> Jaehoon Chung
> 
>> ---
>>
>> Changes in v2:
>>
>>   * Squashed patch 2 and 3 of v1 into 1 patch.
>>
>>  drivers/power/regulator/lp873x_regulator.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/power/regulator/lp873x_regulator.c b/drivers/power/regulator/lp873x_regulator.c
>> index dcb19ff..8c26baf 100644
>> --- a/drivers/power/regulator/lp873x_regulator.c
>> +++ b/drivers/power/regulator/lp873x_regulator.c
>> @@ -263,7 +263,7 @@ static bool ldo_get_enable(struct udevice *dev)
>>  
>>  	ret = lp873x_ldo_enable(dev, PMIC_OP_GET, &enable);
>>  	if (ret)
>> -		return ret;
>> +		return false;
>>  
>>  	return enable;
>>  }
>> @@ -318,7 +318,7 @@ static bool buck_get_enable(struct udevice *dev)
>>  
>>  	ret = lp873x_buck_enable(dev, PMIC_OP_GET, &enable);
>>  	if (ret)
>> -		return ret;
>> +		return false;
>>  
>>  	return enable;
>>  }
>>
> 


More information about the U-Boot mailing list