[U-Boot] [PATCH v2 1/2] regulator: lp87565: Fix the return value of buck_get_enable function

Keerthy j-keerthy at ti.com
Thu Jun 29 09:59:42 UTC 2017



On Thursday 29 June 2017 03:09 PM, Jaehoon Chung wrote:
> Hi,
> 
> On 06/12/2017 11:36 PM, Keerthy wrote:
>> The function wrongly returned an integer while it is supposed to
>> return boolean. Fix that.
>>
>> Fixes: 2dd9dc02a3("power: regulator: lp87565: add regulator support")
>> Reported-by:Nishanth Menon <nm at ti.com>
>> Signed-off-by: Keerthy <j-keerthy at ti.com>
> 
> Applied on u-boot-mmc for PMIC. Thanks!

Jaehoon,

Oops! This is not needed as per latest discussion here:
https://www.mail-archive.com/u-boot@lists.denx.de/msg253113.html

Regards,
Keerthy

> 
> Best Regards,
> Jaehoon Chung
> 
>> ---
>>  drivers/power/regulator/lp87565_regulator.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/power/regulator/lp87565_regulator.c b/drivers/power/regulator/lp87565_regulator.c
>> index 2a0b8ca..e5de578 100644
>> --- a/drivers/power/regulator/lp87565_regulator.c
>> +++ b/drivers/power/regulator/lp87565_regulator.c
>> @@ -174,7 +174,7 @@ static bool buck_get_enable(struct udevice *dev)
>>  
>>  	ret = lp87565_buck_enable(dev, PMIC_OP_GET, &enable);
>>  	if (ret)
>> -		return ret;
>> +		return false;
>>  
>>  	return enable;
>>  }
>>
> 


More information about the U-Boot mailing list