[U-Boot] [PATCH next 1/3] mx6: soc: Move mxs_dma_init() into the mxs nand driver

Fabio Estevam festevam at gmail.com
Fri Jun 30 11:21:14 UTC 2017


Hi Stefano,

On Fri, Jun 30, 2017 at 5:51 AM, Stefano Babic <sbabic at denx.de> wrote:

> But if this is the case, should we not also add a dependency in Kconfig
> for NAND_MXS, selecting automatically APBH_DMA ?
>
> config NAND_MXS
>         bool "MXS NAND support"
>         depends on MX6 || MX7
> +       select APBH_DMA
>

Doing like this still causes the build to fail:

arch/arm/cpu/armv7/built-in.o: In function `arch_cpu_init':
/home/fabio/u-boot/arch/arm/cpu/armv7/mx6/soc.c:432: undefined
reference to `mxs_dma_init'
  LD      u-boot
scripts/Makefile.spl:333: recipe for target 'spl/u-boot-spl' failed
make[1]: *** [spl/u-boot-spl] Error 1
Makefile:1382: recipe for target 'spl/u-boot-spl' failed
make: *** [spl/u-boot-spl] Error 2
make: *** Waiting for unfinished jobs....

SPL builds arch/arm/cpu/armv7/mx6/soc.c, but does not build the
APBH_DMA driver, which provides mxs_dma_init().

That's why I thought in removing mxs_dma_init() from soc.c and put it
inside the mxs_nand.c driver.

If there is some other alternative, please let me know.

Thanks


More information about the U-Boot mailing list