[U-Boot] [PATCH 2/3 v3] arm: mvebu: Add gdsys ControlCenter-Compact board

[Simon Glass]

Hi Mario,

On 22 February 2017 at 08:07, Mario Six <mario.six at gdsys.cc> wrote:
> From: Dirk Eibach <dirk.eibach at gdsys.cc>
>
> The gdsys ControlCenter Digital board is based on a Marvell Armada 38x
> SOC.
>
> It boots from SPI-Flash but can be configured to boot from SD-card for
> factory programming and testing.
>
> On board peripherals include:
> - 2 x GbE
> - Xilinx Kintex-7 FPGA connected via PCIe
> - mSATA
> - USB3 host
> - Atmel TPM
>
> Signed-off-by: Dirk Eibach <dirk.eibach at gdsys.cc>
> Signed-off-by: Mario Six <mario.six at gdsys.cc>
> ---
> Changes in v3:
>
> * Removed gpio_request_simple function
> * Removed dev_get_by_ofname function
> * Removed "plain" GPIOs from the device tree

You are using uclass_get_device_by_name() on an I2C bus. Can you
instead use aliases and uclass_get_device_by_seq()? There is quite a
bit of getting stuff by name. Perhaps it is fine for now, but it would
be better I think to have a driver associated with a DT node, which
has phandles for the things it needs.

Regards,
Simon