[U-Boot] [PATCH] ARM: keystone: Pass SPI MTD partition table via kernel command line

[Tom Rini]

On Sat, Mar 04, 2017 at 06:17:30PM +0530, Vignesh R wrote:

> SPI U-Boot image for K2 boards have now exceeded 512K partition
> allocated to it and no longer fit the partitions defined in kernel DTS
> file. Therefore, pass an updated MTD partition table from U-Boot as
> kernel command line arguments to avoid kernel from accidentally
> modifying boot loader image that has overflowed to next user partition.

So pretty much everyone is now hitting the problem of "U-Boot" gets huge
because we're including N DTB files in the binary in order to pick the
correct one.  We really need to start figuring out a real solution here
that perhaps involves saying where a copy of the tree lives on hardware,
and if not found falling back to a generic functional-enough tree.

> To do is, introduce a common environment file for declaring SPI
> partition so that each individual boards need not repeat the same.
> Choose appropriate SPI bus from board config file and pass it as command
> line argument to kernel.
> 
> Signed-off-by: Vignesh R <vigneshr at ti.com>

So, we want the mtdparts to be passed in via the device tree, not the
command line directly.  I'm also not super keen on anything that adds
more to:

>  include/configs/k2e_evm.h            |  5 +++++
>  include/configs/k2g_evm.h            |  3 +++
>  include/configs/k2hk_evm.h           |  4 ++++
>  include/configs/k2l_evm.h            |  4 ++++
>  include/configs/ti_armv7_keystone2.h |  7 ++++++-

Aside from #include <environment/ti/...h>.

[snip]
> diff --git a/include/environment/ti/spi.h b/include/environment/ti/spi.h
> new file mode 100644
> index 000000000000..6fea9d61f071
> --- /dev/null
> +++ b/include/environment/ti/spi.h
> @@ -0,0 +1,15 @@
> +/*
> + * Copyright (C) 2017 Texas Instruments Incorporated - http://www.ti.com
> + *
> + * Environment variable definitions for SPI on TI boards.
> + *
> + * SPDX-License-Identifier:	GPL-2.0+
> + */
> +
> +#ifndef __TI_SPI_H
> +#define __TI_SPI_H
> +
> +#define SPI0_MTD_PARTS "spi0.0:1m(u-boot-spl)ro,-(misc);\0"
> +#define SPI1_MTD_PARTS "spi1.0:1m(u-boot-spl)ro,-(misc);\0"

OK, but if you look at all of the other SPI mtdparts on TI platforms
this isn't enough and is very keystone specific.  Also, curious, why
aren't you making use of mtdids to give a more descriptive name here?
Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170304/7eed0f47/attachment.sig>