[U-Boot] [PATCH] drivers/usb/ehci: Use platform-specific accessors

Marek Vasut marex at denx.de
Sun Mar 5 01:09:52 UTC 2017


On 03/03/2017 02:22 PM, Alexey Brodkin wrote:
> Hi Marek,
>
> On Fri, 2017-03-03 at 00:57 +0100, Marek Vasut wrote:
>> On 03/01/2017 01:52 PM, Alexey Brodkin wrote:
>>>
>>> Hi Marek,
>>>
>>> On Fri, 2017-02-10 at 21:33 +0100, Marek Vasut wrote:
>>>>
>>>> On 02/10/2017 09:23 PM, Alexey Brodkin wrote:
>>>>>
>>>>>
>>>>> Current implementation doesn't allow utilization of platform-specific
>>>>> reads and writes.
>>>>>
>>>>> But some arches or platforms may want to use their accessors that do
>>>>> some extra work like adding barriers for data serialization etc.
>>>>>
>>>>> Interesting enough OHCI accessors already do that so just aligning
>>>>> EHCI to it now.
>>>>>
>>>>> Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
>>>>> Cc: Marek Vasut <marex at denx.de>
>>>>> Cc: Simon Glass <sjg at chromium.org>
>>>>> Cc: Mateusz Kulikowski <mateusz.kulikowski at gmail.com>
>>>>
>>>> IMO looks OK,
>>>>
>>>> Acked-by: Marek Vasut <marex at denx.de>
>>>>
>>>> I'd like to have a few more reviews of this before applying it for
>>>> 2017.05 . Also CCing Wills, it'd be great to get a test on atheros
>>>> MIPS .
>>>
>>> It's been quite some time since your request to try the patch
>>> on other systems and so far nobody answered. May we consider that
>>> one for application then?
>>>
>>> Essentially I'm not talking about current Tom's master branch
>>> but would be good if the patch lands somewhere and once 2017.03
>>> gets cut is merged in the main branch?
>>
>> Yeah, it's not happening for 2017.03, it'll go into the next one.
>>
>> Can you just rebase and repost the patch please ? I'll get to it next
>> week, I'm traveling until the 10th.
>
> I just tried and the same .mbox applies cleanly on top of today's
> U-Boot master so I believe there's no point in resending it.
>
> Are you OK to just grab existing one?

I no longer have the patch in my mailbox, which is why I asked you to 
resend it. Moreover, did you just test that it applies or did you 
actually build-test and retest the patch on real hardware too ?



More information about the U-Boot mailing list