[U-Boot] [PATCH 1/2] arm: socfpga: Enable abort for DE-nano-SoC SPL uboot load from MMC

[Frank Kunz]

Am 05.03.2017 um 18:36 schrieb Dalon Westergreen:
> On Sun, 2017-03-05 at 18:16 +0100, Marek Vasut wrote:
>> On 03/05/2017 01:54 PM, Frank Kunz wrote:
>>>
>>> This allows the SPL to scan the MMC for a valid uboot image on a second
>>> sector location defined by CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR when
>>> the default location "CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR + first
>>> partition offset" does not contain a valid uboot image.
>>>
>>> Signed-off-by: Frank Kunz <mailinglists at kunz-im-inter.net>
>>> ---
>>> :100644 100644 dd5933d43c... bd3e83ddea... M	include/configs/socfpga_
>>> de0_nano_soc.h
>>>  include/configs/socfpga_de0_nano_soc.h | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/include/configs/socfpga_de0_nano_soc.h
>>> b/include/configs/socfpga_de0_nano_soc.h
>>> index dd5933d43c..bd3e83ddea 100644
>>> --- a/include/configs/socfpga_de0_nano_soc.h
>>> +++ b/include/configs/socfpga_de0_nano_soc.h
>>> @@ -12,6 +12,8 @@
>>>  #define CONFIG_FAT_WRITE
>>>  #define CONFIG_HW_WATCHDOG
>>>
>>> +#define CONFIG_SPL_ABORT_ON_RAW_IMAGE
>>> +
>>>  /* Memory configurations */
>>>  #define PHYS_SDRAM_1_SIZE		0x40000000	/* 1GiB */
>>>
>>>
>> This looks like a horrid hack , didn't Dalon add support into U-Boot SPL 
>> to scan all partitions for the final u-boot image ?
> 
> I did.  The 0xA2 partition can be located on any partition number now.  I
> believe Frank places the SPL image at a 64KB offset from the start of the
> sdcard to skip the MBR/GPT.  But per our previous debate, it is not my
> favored implementation as it relies on the bootrom to load the SPL once.

I put the u-boot at 4x64kiB (sector 0x200) offset on the sdcard. With
CONFIG_SPL_ABORT_ON_RAW_IMAGE config enabled the spl scans first for the
configured partition in the partition table as implemented by Dalon, if
that fails it tries to find the u-boot at sector 0x200 (as configured by
CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR). Without that config the spl
endless retries to find u-boot in the configured partition, which is not
there when using GPT.

> 
> Also, i mentioned before that i would like to hold off on this patch set and
> let Ley Foon et al finish the A10 stuff.
> 
> --dalon
> 
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/listinfo/u-boot
>