[U-Boot] [PATCH 2/5] am335x_evm: Switch to using imply keyword

Lukasz Majewski lukma at denx.de
Sun Mar 5 22:53:43 UTC 2017


Hi Tom,

> These particular SPL options are part of what the ROM provides, but
> for compatibility with how we have previously used them, move them to
> being implied by the board being selected.
> 
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
>  arch/arm/mach-omap2/am33xx/Kconfig | 3 +++
>  board/ti/am335x/Kconfig            | 9 ---------
>  2 files changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/am33xx/Kconfig
> b/arch/arm/mach-omap2/am33xx/Kconfig index 5b5d3f8cec29..5adcead185de
> 100644 --- a/arch/arm/mach-omap2/am33xx/Kconfig
> +++ b/arch/arm/mach-omap2/am33xx/Kconfig
> @@ -15,6 +15,9 @@ config TARGET_AM335X_EVM
>  	select DM_SERIAL
>  	select DM_GPIO
>  	select TI_I2C_BOARD_DETECT
> +	imply SPL_YMODEM_SUPPORT
> +	imply SPL_ENV_SUPPORT
> +	imply SPL_WATCHDOG_SUPPORT

Are you sure that WDT is enabled by ROM by default?

IIRC we must enable it explicitly in the SPL.

>  	help
>  	  This option specifies support for the AM335x
>  	  GP and HS EVM development platforms. The AM335x
> diff --git a/board/ti/am335x/Kconfig b/board/ti/am335x/Kconfig
> index a84e91b3dc56..97374bdc12ae 100644
> --- a/board/ti/am335x/Kconfig
> +++ b/board/ti/am335x/Kconfig
> @@ -1,14 +1,5 @@
>  if TARGET_AM335X_EVM
>  
> -config SPL_ENV_SUPPORT
> -	default y
> -
> -config SPL_WATCHDOG_SUPPORT
> -	default y
> -
> -config SPL_YMODEM_SUPPORT
> -	default y
> -
>  config SYS_BOARD
>  	default "am335x"
>  




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de


More information about the U-Boot mailing list