[U-Boot] [PATCH 2/2] cmd: nand: Make the NAND options default to NAND_SUNXI

[Chen-Yu Tsai]

On Fri, Mar 3, 2017 at 10:32 PM, Maxime Ripard
<maxime.ripard at free-electrons.com> wrote:
> If we depend on the ARCH_SUNXI configuration option, the boards that do not
> have NAND support enabled (with the associated options) will not compile
> anymore.
>
> Depend on the NAND driver configuration option to make sure that is not the
> case.
>
> Reported-by: Chen-Yu Tsai <wens at csie.org>
> Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>

Tested-by: Chen-Yu Tsai <wens at csie.org>

> ---
>  cmd/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 585a00c31f4e..91e3d6a46769 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -438,7 +438,7 @@ config CMD_MMC
>
>  config CMD_NAND
>         bool "nand"
> -       default y if ARCH_SUNXI
> +       default y if NAND_SUNXI

It would be nicer if it were a stronger constraint though. The user can still
enable CMD_NAND (such as by using a config from before this patch was applied)
and still break the build. I understand that this is hard to achieve since each
platform does things a bit differently.

ChenYu

>         help
>           NAND support.
>
> @@ -847,7 +847,7 @@ config CMD_UBI
>         tristate "Enable UBI - Unsorted block images commands"
>         select CRC32
>         select MTD_UBI
> -       default y if ARCH_SUNXI
> +       default y if NAND_SUNXI
>         help
>           UBI is a software layer above MTD layer which admits use of LVM-like
>           logical volumes on top of MTD devices, hides some complexities of
> @@ -862,7 +862,7 @@ config CMD_UBIFS
>         select CRC32
>         select RBTREE if ARCH_SUNXI
>         select LZO if ARCH_SUNXI
> -       default y if ARCH_SUNXI
> +       default y if NAND_SUNXI
>         help
>           UBIFS is a file system for flash devices which works on top of UBI.
>
> --
> 2.11.0
>