[U-Boot] [PATCH] net: zynq_gem: Fix masking of supported phydev features

Joe Hershberger joe.hershberger at gmail.com
Mon Mar 6 22:13:31 UTC 2017


On Sun, Mar 5, 2017 at 8:36 AM, Nathan Rossi <nathan at nathanrossi.com> wrote:
> When the zynq_gem driver initializes the phy it sets the supported
> features that the phy can support and advertise. However instead of
> masking the supported features such that it limits the available
> features it sets the phy to have the exact supported features of the
> zynq_gem. This is problematic as it will enable features that a phy does
> not have or cannot advertise.
>
> Specifically this appears as an issue when using a phy that is only
> capable of 10/100, but the zynq_gem driver will override this and try to
> enable and advertise 10/100/1000.
>
> Reported-by: Arno Steffens <star at gmx.li>
> Fixes: 80243528ef ("net: gem: Fix gem driver on 1Gbps LAN")
> Signed-off-by: Nathan Rossi <nathan at nathanrossi.com>
> Tested-by: Arno Steffens <star at gmx.li>
> Cc: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Michal Simek <michal.simek at xilinx.com>

Acked-by: Joe Hershberger <joe.hershberger at ni.com>


More information about the U-Boot mailing list