[U-Boot] [PATCH v5 09/11] armv8: ls2080a: Drop early MMU for SPL build

Marek Vasut marex at denx.de
Tue Mar 7 03:03:43 UTC 2017


On 03/06/2017 06:02 PM, York Sun wrote:
> Early MMU improves performance especially on emulators. However, the
> early MMU is left enabled after the first stage of SPL boot. Instead
> of flushing D-cache and dealing with re-enabling MMU for the second
> stage U-Boot, disabling it for SPL build simplifies the process. The
> performance penalty is unnoticeable on the real hardware. As of now,
> SPL boot is not supported by existing emulators. So this should have
> no impact on emulators.
>
> Signed-off-by: York Sun <york.sun at nxp.com>

This looks stupid. Why don't you just keep it enabled between SPL and 
U-Boot ? That'd be much more logical and sensible ...

> ---
>
> Changes in v5: None
> Changes in v4: None
> Changes in v3:
>   Add a patch to drop early MMU setup for LS2080A SPL build.
>
> Changes in v2: None
>
>  arch/arm/cpu/armv8/fsl-layerscape/spl.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/spl.c b/arch/arm/cpu/armv8/fsl-layerscape/spl.c
> index 1dabdbb..73a8680 100644
> --- a/arch/arm/cpu/armv8/fsl-layerscape/spl.c
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/spl.c
> @@ -45,9 +45,6 @@ void board_init_f(ulong dummy)
>  {
>  	/* Clear global data */
>  	memset((void *)gd, 0, sizeof(gd_t));
> -#ifdef CONFIG_LS2080A
> -	arch_cpu_init();
> -#endif
>  	board_early_init_f();
>  	timer_init();
>  #ifdef CONFIG_LS2080A
>



More information about the U-Boot mailing list