[U-Boot] [RFC PATCH] kbuild: turn of dtc unit address warnings by default

Tom Rini trini at konsulko.com
Tue Mar 7 18:10:14 UTC 2017


On Wed, Mar 08, 2017 at 02:09:46AM +0900, Masahiro Yamada wrote:
> 2017-02-27 15:24 GMT+09:00 Masahiro Yamada <yamada.masahiro at socionext.com>:
> > DTC 1.4.2 or later checks DT unit-address without reg property and
> > vice-versa, and generates lots of warnings.  Fixing DT files will
> > take for a while.  Until then, let's turn off the check unless
> > building with W=*.
> >
> > Introduce a new helper dtc-option to check if the option is supported
> > in order to suppress warnings on older versions.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> > ---
> >
> > This is one possible answer to Tom's:
> > https://www.mail-archive.com/u-boot@lists.denx.de/msg240328.html
> >
> > He fixed the problem on travis-ci by commit a0f3e3d, but it is still
> > annoying during the regular development.
> > Perhaps we may want to hide the warnings (at least hidden in Linux
> > Kernel by default).
> > Or, is it better to keep it noisy
> > to motivate people to fix their DT files?
> > I am not quite sure...
> >
> > Now I am sending this as RFC patch in case people may want to start discussion.
> >
> > BTW, this is a counter-part of the patch I sent to the Kbuild sub-system
> > (https://patchwork.kernel.org/patch/9592747/)
> > because I want the U-Boot build system with Linux as much as possible.
> > Let's see if I will get possible opinions in the Kbuild review.
> 
> I sent a similar patch for Linux, but
> the response was negative in the Kbuild subsystem.
> 
> So, this patch will be our own, if applied.

I think we should be proactive here and take this patch.  Newer dtc will
be seen more widely I believe as various overlay related changes go in
upstream.  Do you have anything you would change in a v2 non-RFC?

> I think the necessity for this patch comes down to
> how long we expect for fixing DT files.
> 
> 
> The only difficulty is in our basic rule:
> Send patches to Linux first, then import DT to U-Boot.
> 
> Without this, fixing the warnings would be pretty easy...

I guess I would suggest that for the DT files we really own, we should
update them.  Otherwise, just make the warnings happen in the kernel and
correct them and upstream them there.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170307/8e8e8058/attachment.sig>


More information about the U-Boot mailing list