[U-Boot] [PATCH 3/3] arm: bootm: Add dm_remove_devices_flags() call to announce_and_cleanup()

Simon Glass sjg at chromium.org
Mon Mar 13 13:23:54 UTC 2017


Hi Stefan,

On 13 March 2017 at 07:20, Stefan Roese <sr at denx.de> wrote:
> Hi Simon,
>
> On 13.03.2017 13:50, Stefan Roese wrote:
>>
>> On 13.03.2017 13:34, Simon Glass wrote:
>>>
>>> On 10 March 2017 at 06:50, Stefan Roese <sr at denx.de> wrote:
>>>>
>>>> This patch adds a call to dm_remove_devices_flags() to
>>>> announce_and_cleanup() so that drivers that have one of the removal
>>>> flags
>>>> set (e.g. DM_FLAG_ACTIVE_DMA_REMOVE) in their driver struct, may do some
>>>> last-stage cleanup before the OS is started.
>>>>
>>>> Signed-off-by: Stefan Roese <sr at denx.de>
>>>> Cc: Simon Glass <sjg at chromium.org>
>>>> ---
>>>>  arch/arm/lib/bootm.c | 9 +++++++++
>>>>  1 file changed, 9 insertions(+)
>>>
>>>
>>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>>
>>> One more patch with a test?
>>
>>
>> Right, already on the list. Lets see, if I can get this finished today.
>> Otherwise it will have to wait for a few days...
>
>
> Do you have something like the reset test case:
>
> 4581b717 [reset: implement a reset test]
>
> in mind for this selective device remove test? Or something
> completely different?

I think you could create a device with the DMA flag set and see that
it (and only it) is removed. Then another test case which removes
everything. Basically we want to test that each of the flag values
works as expected and at present you only have two).

One way to check that is via device_active().

Regards,
Simon


More information about the U-Boot mailing list