[U-Boot] [PATCH] Pass empty CFLAGS on invocation of libfdt/setup.py

Max Filippov jcmvbkbc at gmail.com
Thu Mar 16 21:56:01 UTC 2017


On Thu, Mar 16, 2017 at 2:11 PM, Tom Rini <trini at konsulko.com> wrote:
> On Thu, Mar 16, 2017 at 11:38:00AM -0700, Max Filippov wrote:
>
>> When building u-boot tools in cross-build environment CFLAGS environment
>> variable set up for target is taken into an account when building code
>> for host. Set it to empty on invocation of python.
>>
>> This fixes the following build errors when cross-compiling for xtensa:
>>
>>   cc1: error: unrecognized command line option "-mlongcalls"
>>   cc1: error: unrecognized command line option "-mauto-litpools"
>>
>> Signed-off-by: Max Filippov <jcmvbkbc at gmail.com>
>> ---
>>  tools/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/Makefile b/tools/Makefile
>> index 1c840d7..c224e8a 100644
>> --- a/tools/Makefile
>> +++ b/tools/Makefile
>> @@ -120,7 +120,7 @@ _libfdt.so-sharedobjs += $(LIBFDT_OBJS)
>>  libfdt:
>>
>>  tools/_libfdt.so: $(patsubst %.o,%.c,$(LIBFDT_OBJS)) tools/libfdt_wrap.c
>> -     LDFLAGS="$(HOSTLDFLAGS)" python $(srctree)/lib/libfdt/setup.py \
>> +     LDFLAGS="$(HOSTLDFLAGS)" CFLAGS="" python $(srctree)/lib/libfdt/setup.py \
>
> I think we need to be passing in HOSTCFLAGS or we'll end up being broken
> on certain other cases (which are broken today I suspect).

I believe that the $(_hostc_flags) in the next line is meant to do exactly that.
There's code in the lib/libfdt/setup.py that uses that parameter.

-- 
Thanks.
-- Max


More information about the U-Boot mailing list