[U-Boot] [PATCH v3 1/2] spl: Add spl_early_init()

Marek Vasut marex at denx.de
Thu Mar 16 22:45:46 UTC 2017


On 03/16/2017 11:39 PM, Simon Glass wrote:
> Hi Marek,
> 
> On 16 March 2017 at 16:37, Marek Vasut <marex at denx.de> wrote:
>> On 03/16/2017 11:28 PM, Simon Glass wrote:
>>> Hi Marek,
>>>
>>> On 16 March 2017 at 16:24, Marek Vasut <marex at denx.de> wrote:
>>>> On 03/16/2017 11:21 PM, Simon Glass wrote:
>>>>> Hi Marek,
>>>>>
>>>>> On 16 March 2017 at 16:17, Marek Vasut <marex at denx.de> wrote:
>>>>>> On 03/15/2017 01:06 AM, Simon Glass wrote:
>>>>>>> From: Eddie Cai <eddie.cai.linux at gmail.com>
>>>>>>>
>>>>>>> At present malloc_base/_limit/_ptr are not initialised in spl_init() when
>>>>>>> we call spl_init() in board_init_f().
>>>>>>
>>>>>> Are you even supposed to call spl_init() from board_init_f() ?
>>>>>> I was under the impression that's supposed to be called by
>>>>>> board_init_r() only.
>>>>>>
>>>>>
>>>>> If you need to use DM then yes you must call it.
>>>>
>>>> SoCFPGA uses DM and doesn't call it until board_init_r() . I think
>>>> there's some significant confusion about how this whole malloc stuff
>>>> should work.
>>>
>>> OK, well if you want to use DM within board_init_f() you must call
>>> this function  If not, then board_init_r() will do it for you. When
>>> does SoCFPGA start using DM?
>>
>> In _r . I don't see anyone using DM in _f though. What is that needed
>> for , serial ?
> 
> See for example board_init_f() in arch/arm/mach-rockchip/rk3288-board-spl.c
> 
> It include sclock, pintctrl, SDRAM at least.

Haaa, OK

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list