[U-Boot] [PATCH v2] ARM: dts: Makefile: use board id to decide which dts compile

[Wenyou.Yang at microchip.com]

Hi Simon,

> -----Original Message-----
> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
> Sent: 2017年3月13日 21:24
> To: Wenyou Yang - A41535 <Wenyou.Yang at microchip.com>
> Cc: U-Boot Mailing List <u-boot at lists.denx.de>; Stephen Warren
> <swarren at nvidia.com>; Andreas Bießmann <andreas at biessmann.org>; Albert
> Aribaud <albert.u.boot at aribaud.net>; Wenyou Yang - A41535
> <Wenyou.Yang at microchip.com>
> Subject: Re: [PATCH v2] ARM: dts: Makefile: use board id to decide which dts
> compile
> 
> Hi Wenyou,
> 
> On 13 March 2017 at 01:39, Wenyou Yang <wenyou.yang at atmel.com> wrote:
> > To avoid to compile all AT91 SoCs' board device tree files, use the
> > board id to decide which device tree file will be compiled, instead of
> > compile all AT91 family files.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang at atmel.com>
> > ---
> >
> > Changes in v2:
> >  - Improve the message log.
> >
> >  arch/arm/dts/Makefile | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index
> > eb68c204bb..77039b88d5 100644
> > --- a/arch/arm/dts/Makefile
> > +++ b/arch/arm/dts/Makefile
> > @@ -2,10 +2,10 @@
> >  # SPDX-License-Identifier:     GPL-2.0+
> >  #
> >
> > -dtb-$(CONFIG_AT91FAMILY) += at91sam9260-smartweb.dtb \
> > -       at91sam9g20-taurus.dtb \
> > -       at91sam9g45-corvus.dtb \
> > -       at91sam9g45-gurnard.dtb
> > +dtb-$(CONFIG_TARGET_SMARTWEB) += at91sam9260-smartweb.dtb
> > +dtb-$(CONFIG_TARGET_TAURUS) += at91sam9g20-taurus.dtb
> > +dtb-$(CONFIG_TARGET_CORVUS) += at91sam9g45-corvus.dtb
> > +dtb-$(CONFIG_TARGET_GURNARD) += at91sam9g45-gurnard.dtb
> 
> What is the motivation for this change?

I thought when building a board, only one device tree to be build.

> 
> I think we should encourage building the DT for all related boards and avoiding
> TARGET in this Makefile. It reduces the number of boards we have to build to find
> a problem. One of the benefits of DT is to support different boards with largely the
> same code. Also it is very fast to build these files so this change probably does
> not reduce build time.

Okay, accepted. Ignored the patch.

> 
> >
> >  dtb-$(CONFIG_S5PC100) += s5pc1xx-smdkc100.dtb
> >  dtb-$(CONFIG_S5PC110) += s5pc1xx-goni.dtb
> > --
> > 2.11.0
> >
> 
> Regards,
> Simon


Best Regards,
Wenyou Yang