[U-Boot] [PATCH] armv8: ls1043a/ls1046aqds: fix the offsets of MTD partitions on Nor flash

[york sun]

On 03/16/2017 06:05 PM, Wenbin Song wrote:
> Hi york,
>
> Do you mean it is not necessary  to supply so much partitions for user, just supplying two partitions, one is reserved for firmware(including RCW, U-boot, Env, PPA, kernel.itb and so on), the other  is the rest of flashes, if not, Could you give me more details?

Wenbin,

I think it depends on what you expect users to do with those partitions. 
That's why I said you don't have use SDK layout.
If you don't expect users to modify (eg. RCW and/or U-Boot), you can 
mark them as "ro". For some space, if you are not sure if the FIT image 
will be there, you can skip it. That's the benefit of using offsets.

York

>
> Best Regards
> Wenbin Song
>
>
>
> -----Original Message-----
> From: york sun
> Sent: Thursday, March 16, 2017 1:14 AM
> To: Wenbin Song <wenbin.song at nxp.com>; Mingkai Hu <mingkai.hu at nxp.com>; sjg at chromium.org; Z.Q. Hou <zhiqiang.hou at nxp.com>; M.H. Lian <minghuan.lian at nxp.com>; u-boot at lists.denx.de
> Subject: Re: [PATCH] armv8: ls1043a/ls1046aqds: fix the offsets of MTD partitions on Nor flash
>
> On 03/13/2017 11:06 PM, Wenbin song wrote:
>> Fix the offsets of MTD partitions on Nor flash on ls1043ardb,
>> ls1043aqds and ls1046aqds boards.
>>
>> Signed-off-by: Wenbin Song <wenbin.song at nxp.com>
>> ---
>>  include/configs/ls1043a_common.h | 7 ++++---
>>  include/configs/ls1046aqds.h     | 7 ++++---
>>  2 files changed, 8 insertions(+), 6 deletions(-)
>>
>> diff --git a/include/configs/ls1043a_common.h
>> b/include/configs/ls1043a_common.h
>> index c4b05e0..ca845b6 100644
>> --- a/include/configs/ls1043a_common.h
>> +++ b/include/configs/ls1043a_common.h
>> @@ -192,10 +192,11 @@
>>  #else
>>  #define MTDPARTS_DEFAULT "mtdparts=60000000.nor:1m(nor_bank0_rcw)," \
>>  			"1m(nor_bank0_uboot),1m(nor_bank0_uboot_env)," \
>> -			"1m(nor_bank0_fman_uconde),40m(nor_bank0_fit)," \
>> -			"1m(nor_bank4_rcw),1m(nor_bank4_uboot)," \
>> +			"1m(nor_bank0_fman_uconde),"\
>> +			"40m at 1100000(nor_bank0_fit)," \
>> +			"1m at 4000000(nor_bank4_rcw),1m(nor_bank4_uboot)," \
>>  			"1m(nor_bank4_uboot_env),1m(nor_bank4_fman_ucode)," \
>> -			"40m(nor_bank4_fit);7e800000.flash:" \
>> +			"40m at 5100000(nor_bank4_fit);7e800000.flash:" \
>>  			"1m(nand_uboot),1m(nand_uboot_env)," \
>>  			"20m(nand_fit);spi0.0:1m(uboot)," \
>>  			"5m(kernel),1m(dtb),9m(file_system)"
>> diff --git a/include/configs/ls1046aqds.h
>> b/include/configs/ls1046aqds.h index 4b3b21e..e045249 100644
>> --- a/include/configs/ls1046aqds.h
>> +++ b/include/configs/ls1046aqds.h
>> @@ -487,10 +487,11 @@ unsigned long get_board_ddr_clk(void);  #else
>> #define MTDPARTS_DEFAULT "mtdparts=60000000.nor:1m(nor_bank0_rcw)," \
>>  			"1m(nor_bank0_uboot),1m(nor_bank0_uboot_env)," \
>> -			"1m(nor_bank0_fman_uconde),40m(nor_bank0_fit)," \
>> -			"1m(nor_bank4_rcw),1m(nor_bank4_uboot)," \
>> +			"1m(nor_bank0_fman_uconde),"\
>> +			"40m at 1100000(nor_bank0_fit)," \
>> +			"1m at 4000000(nor_bank4_rcw),1m(nor_bank4_uboot)," \
>>  			"1m(nor_bank4_uboot_env),1m(nor_bank4_fman_ucode)," \
>> -			"40m(nor_bank4_fit);7e800000.flash:" \
>> +			"40m at 5100000(nor_bank4_fit);7e800000.flash:" \
>>  			"4m(nand_uboot),36m(nand_kernel)," \
>>  			"472m(nand_free);spi0.0:2m(uboot)," \
>>  			"14m(free)"
>>
>
> Wenbin,
>
> Maybe you can use more generic partitions for the NOR and put more detail in comment. I believe the RCW, U-Boot, Env, Fman ucode, PPA are at fixed locations. But the rest is up to user. We cannot assume the layout is identical to SDK. Same goes to NAND partitions.
>
> York
>