[U-Boot] [PATCH 10/14] drivers: net: add MV88E6xx to Kconfig

Tim Harvey tharvey at gateworks.com
Fri Mar 17 13:13:36 UTC 2017


On Fri, Mar 17, 2017 at 3:59 AM, Stefano Babic <sbabic at denx.de> wrote:
> On 13/03/2017 16:51, Tim Harvey wrote:
>> Signed-off-by: Tim Harvey <tharvey at gateworks.com>
>> ---
>>  drivers/net/Kconfig | 18 ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>>
>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>> index 078d5a8..a24bb06 100644
>> --- a/drivers/net/Kconfig
>> +++ b/drivers/net/Kconfig
>> @@ -141,6 +141,24 @@ config MACB
>>         GEM (Gigabit Ethernet MAC) found in some ARM SoC devices.
>>         Say Y to include support for the MACB/GEM chip.
>>
>> +config MV88E61XX_SWITCH
>> +     bool "Marvell MV88E61xx Gigabit switch support"
>> +     help
>> +       This driver supports the mv88e6176 and similar switches.
>> +
>> +if MV88E61XX_SWITCH
>> +
>> +config MV88E61XX_CPU_PORT
>> +     int "CPU Port"
>> +
>> +config MV88E61XX_PHY_PORTS
>> +     hex "Bitmask of PHY Ports"
>> +
>> +config MV88E61XX_FIXED_PORTS
>> +     hex "Bitmask of PHYless serdes Ports"
>> +
>> +endif # MV88E61XX_SWITCH
>> +
>>  config PCH_GBE
>>       bool "Intel Platform Controller Hub EG20T GMAC driver"
>>       depends on DM_ETH && DM_PCI
>>
>
>
> I do not understand this patch: the switch is already added into
> drivers/net/phy/Kconfig, where it should be, and it should not be in
> drivers/net/Kconfig where you want to put it. So I am expecting you add
> if MV88E61XX_SWITCH into drivers/net/phy/Kconfig and not here.
>
> Added Joe as network maintainer.
>

Stefano,

Your right - I must have typo'd my grep when I was looking for it in Kconfig.

drop this patch please, and I will submit a v2 of 'imx: ventana: add
GW5904 support' that adds the switch properly. Let me know if you
would rather I resubmit the series.

Thanks,

Tim


More information about the U-Boot mailing list