[U-Boot] [PATCH v2 1/2] x86: Add SCU IPC driver for Intel MID platforms

Andy Shevchenko andriy.shevchenko at linux.intel.com
Mon Mar 20 13:27:09 UTC 2017


On Sun, 2017-03-19 at 20:30 -0600, Simon Glass wrote:
> Hi Andy,
> 
> On 15 March 2017 at 12:42, Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:
> > From: Felipe Balbi <felipe.balbi at linux.intel.com>
> > 
> > Intel MID platforms have few microcontrollers inside SoC, one of
> > them
> > is so called System Controller Unit (SCU).
> > 
> > Here is the driver to communicate with microcontroller.
> > 
> > Signed-off-by: Vincent Tinelli <vincent.tinelli at intel.com>
> > Signed-off-by: Felipe Balbi <felipe.balbi at linux.intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> > ---
> >  arch/x86/Kconfig           |   2 +
> >  arch/x86/include/asm/cpu.h |   1 +
> >  arch/x86/include/asm/scu.h |  28 ++++++++
> >  arch/x86/lib/Makefile      |   1 +
> >  arch/x86/lib/scu.c         | 168
> > +++++++++++++++++++++++++++++++++++++++++++++
> >  5 files changed, 200 insertions(+)
> >  create mode 100644 arch/x86/include/asm/scu.h
> >  create mode 100644 arch/x86/lib/scu.c
> 
> Since this is a v2 patch can you please include a change log?

Yes.

Common:
- convert to use REGMAP instead of constant addressed IO
- rewrite as UCLASS_SYSCON modules
- move to arch/x86/lib since it's related to x86 only and there are
already another UCLASS_SYSCON modules there

SCU:
- convert function documentation to have header and body and be
consistent
- shrink header and remove unneeded attributes
- drop busy loop counter from 3m to 100k as per driver in Linux kernel

PMU:
- convert to be more generic and move Tangier related part to its own
folder (the latter out of scope of this series)

-- 
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy


More information about the U-Boot mailing list