[U-Boot] [PATCH v2] drivers/net/phy: add fixed-phy / fixed-link support

[Hannes Schmelzer]

On 03/21/2017 07:26 PM, Joe Hershberger wrote:
Hi Joe,

many thanks for your input, i will do some rework and send v3.
But a few words about my doing below.
> On Tue, Mar 21, 2017 at 4:30 AM, Hannes Schmelzer <oe5hpm at oevsv.at> wrote:
>> From: Hannes Schmelzer <hannes.schmelzer at br-automation.com>
>>
>> This patch adds support for having a "fixed-link" to some other MAC
>> (like some embedded switch-device).
(....)
>> +       priv->duplex = fdtdec_get_bool(gd->fdt_blob, ofnode, "full-duplex");
>> +       priv->pause = fdtdec_get_bool(gd->fdt_blob, ofnode, "pause");
>> +       priv->asym_pause = fdtdec_get_bool(gd->fdt_blob, ofnode, "asym-pause");
>> +
>> +       /* set this for preventing stack doing some unary reset */
> Please clarify this comment.
During startup  phy_reset(...) is called from phy_connect_dev(...) to 
reset the connected phy.
This isn't done here due to 2 points:
a) reset of a fixed link is unary
b) reset would fail since the code wants to write mii registers to not 
physically existing device.

OK?

cheers,
Hannes