[U-Boot] [PATCH 18/22] x86: acpi: Refactor acpi_resume()

Simon Glass sjg at chromium.org
Tue Mar 21 20:07:09 UTC 2017


Hi Bin,

On 16 March 2017 at 08:26, Bin Meng <bmeng.cn at gmail.com> wrote:
> To do something more in acpi_resume() like turning on ACPI mode,
> we need locate ACPI FADT table pointer first. But currently this
> is done in acpi_find_wakeup_vector().
>
> This changes acpi_resume() signature to accept ACPI FADT pointer
> as the parameter. A new API acpi_find_fadt() is introduced, and
> acpi_find_wakeup_vector() is updated to use FADT pointer as the
> parameter as well.
>
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> ---
>
>  arch/x86/cpu/cpu.c                |  6 +++---
>  arch/x86/include/asm/acpi_s3.h    |  5 +++--
>  arch/x86/include/asm/acpi_table.h |  3 ++-
>  arch/x86/lib/acpi_s3.c            |  7 ++++++-
>  arch/x86/lib/acpi_table.c         | 16 +++++++++++-----
>  5 files changed, 25 insertions(+), 12 deletions(-)
>

Reviewed-by: Simon Glass <sjg at chromium.org>

Can you add a few function comments in the header file?

Regards,
Simon


More information about the U-Boot mailing list