[U-Boot] [PATCH] zynq: Move ENV location selection from zynq-common.h to config files.

[Michal Simek]

On 22.3.2017 15:49, Tom Rini wrote:
> On Wed, Mar 22, 2017 at 03:30:09PM +0100, Michal Simek wrote:
>> On 21.3.2017 19:56, Philip Balister wrote:
>>> The ifdef's in zynq-common.h do a partial selection of the u-boot environment
>>> storage location. As u-boot added more, the ifdefs no longe cope with all
>>> possible cases. Rather than correct the logic there, move the selection
>>> options into the board specific config files.
>>>
>>> Signed-off-by: Philip Balister <philip at opensdr.com>
>>> ---
>>>  configs/zynq_microzed_defconfig    |  1 +
>>>  configs/zynq_picozed_defconfig     |  1 +
>>>  configs/zynq_zc702_defconfig       |  1 +
>>>  configs/zynq_zc706_defconfig       |  1 +
>>>  configs/zynq_zc770_xm010_defconfig |  2 +-
>>>  configs/zynq_zc770_xm011_defconfig |  2 +-
>>>  configs/zynq_zc770_xm012_defconfig |  2 +-
>>>  configs/zynq_zc770_xm013_defconfig |  2 +-
>>>  configs/zynq_zed_defconfig         |  1 +
>>>  configs/zynq_zybo_defconfig        |  2 ++
>>>  include/configs/zynq-common.h      | 10 ----------
>>>  11 files changed, 11 insertions(+), 14 deletions(-)
>>>
>>> diff --git a/configs/zynq_microzed_defconfig b/configs/zynq_microzed_defconfig
>>> index 4093618..b95c7d3 100644
>>> --- a/configs/zynq_microzed_defconfig
>>> +++ b/configs/zynq_microzed_defconfig
>>> @@ -5,6 +5,7 @@ CONFIG_DEFAULT_DEVICE_TREE="zynq-microzed"
>>>  CONFIG_FIT=y
>>>  CONFIG_FIT_SIGNATURE=y
>>>  CONFIG_FIT_VERBOSE=y
>>> +CONFIG_SYS_EXTRA_OPTIONS="ENV_IS_IN_SPI_FLASH"
> 
> No, we don't want to add more to SYS_EXTRA_OPTIONS, we want to start
> moving these options to Kconfig itself, directly.  I'm happy to run the
> big migration of the configs so long as the Kconfig part has been tested
> in at least a few cases to be right.  Thanks!

ah right - it is even deprecated in Kconfig.

Thanks for reminder.
Michal