[U-Boot] [PATCH v4] drivers/net/phy: add fixed-phy / fixed-link support

Hannes Schmelzer hannes at schmelzer.or.at
Thu Mar 23 14:16:11 UTC 2017



On 23.03.2017 15:03, Christian Gmeiner wrote:
> Hi
Hi Christian,
>
>> +int fixedphy_probe(struct phy_device *phydev)
>> +{
>> +       struct fixed_link *priv;
>> +       int ofnode = phydev->addr;
>> +       u32 val;
>> +
>> +       /* check for mandatory properties within fixed-link node */
>> +       val = fdt_getprop_u32_default_node(gd->fdt_blob,
>> +                                          ofnode, 0, "speed", 0);
>> +       if (val != SPEED_10 && val != SPEED_1000 && val != SPEED_1000) {
>
> Still wrong - SPEED_100 is missing.
>
>            if (val != SPEED_10 && val != SPEED_100 && val != SPEED_1000) {
What a mess ... looked 100 times to it ...
Sending now a v5. Many thanks.

cheers,
Hannes



More information about the U-Boot mailing list