[U-Boot] [PATCH v4 3/3] rtc: Add DM support to ds1307

Chris Packham judge.packham at gmail.com
Mon May 1 03:11:40 UTC 2017


On Sun, Apr 30, 2017 at 3:49 PM, Simon Glass <sjg at chromium.org> wrote:
> On 28 April 2017 at 21:20, Chris Packham <judge.packham at gmail.com> wrote:
>> Add an implementation of the ds1307 driver that uses the driver model
>> i2c APIs.
>>
>> Signed-off-by: Chris Packham <judge.packham at gmail.com>
>>
>> ---
>>
>> Changes in v4:
>> - move #ifdef CONFIG_CMD_DATE inside the legacy block
>> - use driver data to identify specific chip
>> - terminate the #ifndef with a #endif rather than having backwards logic
>>   (off-list feedback).
>>
>> Changes in v3: None
>> Changes in v2: None
>>
>>  drivers/rtc/Kconfig  |   7 ++
>>  drivers/rtc/ds1307.c | 209 ++++++++++++++++++++++++++++++++++++++++++++++-----
>>  2 files changed, 196 insertions(+), 20 deletions(-)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> I suggest capitals for ds_1307, etc.

I copied the enum from Linux so unless that's a hard objection I'd
like to keep it as-is.


More information about the U-Boot mailing list