[U-Boot] [PATCH 2/2] Enable PXE boot on meson-gxbb.

[Andreas Färber]

Am 17.04.2017 um 00:04 schrieb Andreas Färber:
> Am 17.04.2017 um 00:01 schrieb Vagrant Cascadian:
>> Enable distro_bootcmd PXE functions on meson-gxbb systems.
>>
>> While DHCP boot is already supported, the format is fairly u-boot
>> specific, while PXE boot supports the widely used syslinux style boot
>> configuration format.
>>
>> Signed-off-by: Vagrant Cascadian <vagrant at debian.org>
>> ---
>>
>>  include/configs/meson-gxbb-common.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/configs/meson-gxbb-common.h b/include/configs/meson-gxbb-common.h
>> index c3229ea2cf..0339feaed9 100644
>> --- a/include/configs/meson-gxbb-common.h
>> +++ b/include/configs/meson-gxbb-common.h
>> @@ -41,6 +41,7 @@
>>  #define BOOT_TARGET_DEVICES(func) \
>>  	func(MMC, mmc, 0) \
>>  	func(MMC, mmc, 1) \
>> +	func(PXE, pxe, na) \
>>  	func(DHCP, dhcp, na)
>>  
>>  #include <config_distro_bootcmd.h>
> 
> This should go after DHCP as discussed a while ago.

MMC distro boot has now been merged, so you could rebase.

Somehow I do not see replies to your previous suggestion in January,
where I thought Alex and others had commented on it (we did discuss that
somewhere...), and checking

git grep -C 1 "func(PXE" -- include/configs/

indeed all boards that do enable PXE have it before DHCP, although there
are quite a few that have DHCP only:

git grep -C 1 "func(DHCP" -- include/configs/

So I won't object to you adding it here, but my concerns about the
timeouts incurred by the per-byte config fallbacks still remain.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)