[U-Boot] [PATCH v4 05/11] tegra: select ARM_GIC for Tegra SoCs

[Stephen Warren]

On 05/02/2017 12:51 AM, Antoine Tenart wrote:
> Hi Stephen,
>
> On Mon, May 01, 2017 at 09:34:43AM -0600, Stephen Warren wrote:
>>> Antoine Tenart wrote at Sunday, April 30, 2017 6:30 AM:
>>>>
>>>> Select the newly introduced ARM_GIC option to the relevant configuration
>>>> which also have a psci implementation.
>>
>> It's true that all Tegra have ARM_GIC.
>>
>> However, the commit description makes it sound as if enabling ARM_GIC
>> enables PSCI support. That doesn't seem likely, but if it is true, I don't
>> think this patch is correct. What is the actual implication of this patch?
>
> The commit description is misleading then. Selecting ARM_GIC doesn't
> enables PSCI support. However the common PSCI code is using the GIC
> which is not possible on all SoC. This new ARM_GIC option helps using
> (or not) the GIC specific code in PSCI. So, it's important to select
> this new option on a SoC previously supporting PSCI in U-Boot but it
> won't do anything if the SoC doesn't have a PSCI implementation.
>
> As for Tegra SoCs, a few of them provide a PSCI implementation. At first
> I selected ARM_GIC only for those providing a PSCI implementation but we
> decided to do this directly for all Tegra SoCs (in the v3 thread) as
> this option doesn't do anything not related to PSCI, and because all
> Tegra SoCs do have a GIC.

OK, then the patch content sounds fine. I'd suggest rewording the commit 
description to more fully explain the situation; something similar to 
what you wrote in email above. Thanks.