[U-Boot] [PATCH 3/3] spl: dfu: reduce spl-dfu MLO size

B, Ravi ravibabu at ti.com
Wed May 3 12:45:10 UTC 2017


Hi Tom

>> 
>> >>OK.  I think we need to introduce SPL_DFU_xxx Kconfig options, and 
>> >>use
>> >>CONFIG_IS_ENABLED(DFU_xxx) so that we will get things enabled/disabled (and discarded) as needed.
>> 
>> >Ok, will do.
>> 
>> Correct me if I am wrong, I need understand if we introduce say 
>> SPL_DFU_MMC Kconfig options, then whether need to support DFU_MMC in 
>> SPL ?
>> Again this will increase the SPL-size, and also DFU_MMC uses
>> run_command() again, there is dependency of cli.c, hush etc. 

>SPL_DFU_MMC will only increase the size of SPL if it's enabled.  Being able to switch to testing with CONFIG_IS_ENABLED(DFU_xxx) means that we'll be able to keep the space savings while also not making various parts of the code harder to read with more #ifdef tests.

Ok, since SPL_DFU_MMC will be added in Kconfig, if SPL_DFU_MMC is selected it will increase the SPL size, it means SPL_DFU_MMC dependency code shall be included (like cli,c, hush etc).
When SPL_DFU_MMC is not selected then automatically SPL size will be reduced. 

Thanks. 

Regards
Ravi


More information about the U-Boot mailing list