[U-Boot] [PATCH 1/5] dm: clk: add BCM6345 clock driver

[Simon Glass]

Hi Alvarao,

On 3 May 2017 at 07:09, Álvaro Fernández Rojas <noltari at gmail.com> wrote:
> This is a simplified version of linux/arch/mips/bcm63xx/clk.c
>
> Signed-off-by: Álvaro Fernández Rojas <noltari at gmail.com>
> ---
>  drivers/clk/Kconfig       |  8 +++++
>  drivers/clk/Makefile      |  1 +
>  drivers/clk/clk_bcm6345.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 87 insertions(+)
>  create mode 100644 drivers/clk/clk_bcm6345.c

Reviewed-by: Simon Glass <sjg at chromium.org>

nits below

>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 5ca958c..fa3fbe2 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -20,6 +20,14 @@ config SPL_CLK
>           setting up clocks within SPL, and allows the same drivers to be
>           used as U-Boot proper.
>
> +config CLK_BCM6345
> +       bool "Enable clock driver support for BCM6345"
> +       depends on CLK && ARCH_BMIPS
> +       default y
> +       help
> +         This clock driver adds support for clock realted settings for
> +         BCM6345.

Can you give a bit more detail here? Does it support all clocks?

> +
>  config CLK_BOSTON
>         def_bool y if TARGET_BOSTON
>         depends on CLK
> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
> index 01a8cd6..2746a80 100644
> --- a/drivers/clk/Makefile
> +++ b/drivers/clk/Makefile
> @@ -17,6 +17,7 @@ obj-y += tegra/
>  obj-$(CONFIG_CLK_UNIPHIER) += uniphier/
>  obj-$(CONFIG_CLK_EXYNOS) += exynos/
>  obj-$(CONFIG_CLK_AT91) += at91/
> +obj-$(CONFIG_CLK_BCM6345) += clk_bcm6345.o
>  obj-$(CONFIG_CLK_BOSTON) += clk_boston.o
>  obj-$(CONFIG_ARCH_ASPEED) += aspeed/
>  obj-$(CONFIG_STM32F7) += clk_stm32f7.o
> diff --git a/drivers/clk/clk_bcm6345.c b/drivers/clk/clk_bcm6345.c
> new file mode 100644
> index 0000000..0b52079
> --- /dev/null
> +++ b/drivers/clk/clk_bcm6345.c
> @@ -0,0 +1,78 @@
> +/*
> + * Copyright (C) 2017 Álvaro Fernández Rojas <noltari at gmail.com>
> + *
> + * Derived from linux/arch/mips/bcm63xx/clk.c:
> + *     Copyright (C) 2008 Maxime Bizon <mbizon at freebox.fr>
> + *
> + * SPDX-License-Identifier:    GPL-2.0+
> + */
> +
> +#include <clk-uclass.h>
> +#include <common.h>

This should always go first.

Regards,
Simon