[U-Boot] [PATCHv2 5/5] ARM64: poplar: hi3798cv200: u-boot support for Poplar 96Boards

[Tom Rini]

On Mon, May 08, 2017 at 10:56:41AM +0200, Jorge Ramirez-Ortiz wrote:

> This port adds support for:
>         1) Serial
>         2) eMMC
>         3) USB
[snip]
> diff --git a/include/configs/poplar.h b/include/configs/poplar.h
> new file mode 100644
> index 0000000..fb0ca19
> --- /dev/null
> +++ b/include/configs/poplar.h

So, a general problem here.  Please figure out ways to change things
like:

> +/* memory */
> +#define PHYS_SDRAM_1				0x00000000
> +#define PHYS_SDRAM_1_SIZE			0x40000000

To either not be needed, or use the value directly.  We want to be able
to drop include/configs/*.h in due time.  So for example:

> +#define CONFIG_NR_DRAM_BANKS			4
> +#define DRAM_BANK_SIZE				0x10000000
> +
> +/* sys */
> +#define CONFIG_SYS_BOOTM_LEN 			0x1400000
> +#define CONFIG_SYS_INIT_RAM_SIZE		0x100000
> +#define CONFIG_SYS_SDRAM_BASE			PHYS_SDRAM_1

This can just use 0x00000000

> +#define CONFIG_SYS_INIT_SP_ADDR			(PHYS_SDRAM_1 + 0x200000)

We aren't using some sort of SRAM/IRAM/etc ?

> +#define CONFIG_SYS_LOAD_ADDR			(PHYS_SDRAM_1 + 0x800000)
> +#define CONFIG_SYS_MALLOC_LEN			(PHYS_SDRAM_1 + SZ_8M)

This should just be SZ_8M (or really, larger, 32M most likely).

> +/* generic gimer */
> +#define COUNTER_FREQUENCY			19000000
> +
> +/* generic interrupt controller definitions */
> +#define GICD_BASE				0xF1001000
> +#define GICC_BASE				0xF1002000

These probably belong elsewhere, arch/arm/include/asm/arch-.../

> +/*****************************************************************************
> + *  Initial environment variables
> + *****************************************************************************/
> +
> +#define CONFIG_NETMASK				255.255.255.0
> +#define CONFIG_SERVERIP				192.168.1.4
> +#define CONFIG_GATEWAYIP			192.168.1.1

NAK.  We really should be dropping these entirely I believe.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170508/42f14b82/attachment.sig>