[U-Boot] [PATCHv4 3/3] ARM64: poplar: hi3798cv200: u-boot support for Poplar 96Boards

[Jorge Ramirez]

On 05/08/2017 07:29 PM, Tom Rini wrote:
> On Mon, May 08, 2017 at 06:36:43PM +0200, Jorge Ramirez-Ortiz wrote:
>
>> This port adds support for:
>>          1) Serial
>>          2) eMMC
>>          3) USB
> [snip]
>>   arch/arm/dts/hi3798cv200.dtsi                      |   3 +
>>   arch/arm/dts/poplar-uboot.dtsi                     |  24 +++
> [snip]
>> diff --git a/arch/arm/dts/hi3798cv200.dtsi b/arch/arm/dts/hi3798cv200.dtsi
>> index 75865f8..caa17de 100644
>> --- a/arch/arm/dts/hi3798cv200.dtsi
>> +++ b/arch/arm/dts/hi3798cv200.dtsi
>> @@ -409,3 +409,6 @@
>>   		};
>>   	};
>>   };
>> +
>> +#include "poplar-uboot.dtsi"
> NAK, that's not the mechanism, we have one that will automatically
> include the right file.  IF it's needed.
>
>> diff --git a/arch/arm/dts/poplar-uboot.dtsi b/arch/arm/dts/poplar-uboot.dtsi
>> new file mode 100644
>> index 0000000..8a9668a
>> --- /dev/null
>> +++ b/arch/arm/dts/poplar-uboot.dtsi
>> @@ -0,0 +1,24 @@
>> +/*
>> + * U-Boot addition to:
>> + *  1) initialize the console clock rate.
>> + *  2) provide support for the generic-ehci USB driver currently not available
>> + *     in the linux kernel (8/May/2017).
>> + *
>> + * (C) Copyright 2017 Jorge Ramirez-Ortiz <jorge.ramirez-ortiz at linaro.org>
>> + *
>> + * SPDX-License-Identifier:     GPL-2.0+
>> + */
>> +
>> +&soc {
>> +	usb2: ehci at 9890000 {
>> +		compatible = "generic-ehci";
>> +		reg = <0x9890000 0x100>;
>> +		status = "okay";
>> +	};
>> +};
>> +
>> +&uart0 {
>> +	clock = <75000000>;
>> +	status = "okay";
>> +};
> These are NOT U-Boot specific properties, they should be in the generic
> board dts file.  Lets wait for Alex to chime in on the status of getting
> the dts file / etc merged into Linux before doing v5.  Thanks!
>

hey Tom, I am not sure how to move this forward really so let me clarify 
where I think we stand:

1. The linux kernel does not need the clock property in the uart nodes 
(only u-boot does: serial_pl01x.c needs fixing).
2. ehci is not present in the linux kernel poplar dts yet but it will be 
eventually.

with this in mind, what is blocking the acceptance of the patchset?

I can do v5 using the linux kernel dts as is and creating a 
hi3798cv200-u-boot.dtsi that simply adds the nodes above (this time no 
#include required :) )

Then when ehci is added to the kernel, the ehci node can be removed from 
u-boot.dtsi
And when uboot updates its pl01x.c serial driver,  the uart0 node can be 
removed and the u-boot.dtsi filed completely deleted.

would this be acceptable? if not, what would you see us doing?