[U-Boot] [PATCH] board_f: skip timer_init() on Coldfire archs

Simon Glass sjg at chromium.org
Wed May 10 22:03:09 UTC 2017


Hi Angelo,

On 10 May 2017 at 15:58, Angelo Dureghello <angelo at sysam.it> wrote:
> Coldfire arch is not happy with timer_init since interrupt handlers
> are still not set at that stage, and the boot hangs silently.
>
> Signed-off-by: Angelo Dureghello <angelo at sysam.it>
> ---
>  common/board_f.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/common/board_f.c b/common/board_f.c
> index d9431ee79a..30e588e213 100644
> --- a/common/board_f.c
> +++ b/common/board_f.c
> @@ -740,7 +740,9 @@ static const init_fnc_t init_sequence_f[] = {
>         /* get CPU and bus clocks according to the environment variable */
>         get_clocks,             /* get CPU and bus clocks (etc.) */
>  #endif
> +#if !defined(CONFIG_M68K)
>         timer_init,             /* initialize timer */
> +#endif
>  #if defined(CONFIG_BOARD_POSTCLK_INIT)
>         board_postclk_init,
>  #endif
> --
> 2.11.0
>

I'm really hoping we can get rid of all arch-specific things from the
init sequence.

Is there no way that m68k can init its timer here? Or perhaps it could
be a nop function?

Regards,
Simon


More information about the U-Boot mailing list