[U-Boot] [PATCH v2 5/9] Fix up inclusion of common.h

[Masahiro Yamada]

Hi Simon

2017-05-11 6:43 GMT+09:00 Tom Rini <trini at konsulko.com>:
> On Mon, May 01, 2017 at 09:18:48AM -0600, Simon Glass wrote:
>
>> It is good practice to include common.h as the first header. This ensures
>> that required features like the DECLARE_GLOBAL_DATA_PTR macro,
>> configuration options and common types are available.
>>
>> Fix up some files which currently don't do this. This is necessary because
>> driver model will soon start using global data and configuration in the
>> dm/ofnode.h header file, included via dm.h.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>
> Reviewed-by: Tom Rini <trini at konsulko.com>


NACK.

include/common.h is really bad idea
and this is a step backward.

If you need something in your include/dm/ofnode.h
you should include needed header(s) from it.

Why do you need to touch lots of C files?


-- 
Best Regards
Masahiro Yamada