[U-Boot] [RFC] drivers: pci: imx: add imx_pcie_remove function

[Stefano Babic]

Hi Fabio,

On 11/05/2017 13:06, Fabio Estevam wrote:
> On Thu, May 11, 2017 at 6:01 AM, Peter Senna Tschudin
> <peter.senna at collabora.com> wrote:
> 
>> Thank you for working on this! Your patch worked for me, but I needed to
>> add an "extern void imx_pcie_remove(void);" before calling the function,
>> which probably means I'm missing something.
> 
> The extern should be added into a header file.
> 
>> After applying this patch to u-boot, u-boot can initialize PCI and
>> 4.11.0-next-20170510 will boot. Without your patch 4.11.0-next-20170510
>> do not boot if u-boot initialize the PCI bus.
>>
>> Thanks a lot!
>>
>> Here is the patch I'm using for our board:
> 
> Stefano,
> 
> The patches that Tim/Peter posted solve a kernel hang with kernel 4.11
> on mx6q when U-Boot has PCI support.
> 
> Could you please take a look and let us know if there is a more
> generic way to fix this issue, like fixing it for all mx6qdl boards
> that have PCI support?
> 
> I understand that ideally the imx6 pci driver should be converted to
> driver model and then we add the .remove hook, like Lucas did for
> Barebox:
> https://git.pengutronix.de/cgit/barebox/commit/?id=f1da98da2760c21487bbba8f7fb957c843a22896
> 
> While the imx pci driver is not converted to device model, would you
> be willing to accept such per board patches for the time being?
> 
> Please advise.


Ok - let wait for Tim's answer, if he has enough time to work on this to
move to DM. If not, it will be ok for now to fix it in this way, hoping
to move soon to DM.

Regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================