[U-Boot] [U-Boot, 4/8] cmd/led.c: Remove unnecessary check on 'cmd' value

Tom Rini trini at konsulko.com
Fri May 12 17:23:58 UTC 2017


On Wed, May 10, 2017 at 03:20:14PM -0400, Tom Rini wrote:

> We first check that if argc is less than 2 we return CMD_RET_USAGE.  We
> then see if argc is greater than 2 and if so call get_led_cmd() to set
> 'cmd' and otherwise set it to LEDST_COUNT (which will always be positive
> as it's an enum with 0 already assigned).  Therefore the test on if cmd
> is less than 0 will always be false and simply be omitted.  Reported by
> clang-3.8.
> 
> Signed-off-by: Tom Rini <trini at konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170512/3d8a1cd7/attachment.sig>


More information about the U-Boot mailing list