[U-Boot] [PATCH V5 4/4] rockchip: rk3288: enable rockusb support on rk3288 based device

[Simon Glass]

On 7 May 2017 at 20:38, Eddie Cai <eddie.cai.linux at gmail.com> wrote:
> this patch enable rockusb support on rk3288 based device.
>
> Signed-off-by: Eddie Cai <eddie.cai.linux at gmail.com>
>
> Changes in v5:
> -none
>
> Changes in v4:
> -move to rk3288_common.h
>
> Changes in v3:
> -move to defconfig
>
> ---
>  include/configs/rk3288_common.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/include/configs/rk3288_common.h b/include/configs/rk3288_common.h
> index e7a8f72..0fe6560 100644
> --- a/include/configs/rk3288_common.h
> +++ b/include/configs/rk3288_common.h
> @@ -72,6 +72,10 @@
>  #define CONFIG_FASTBOOT_BUF_ADDR       CONFIG_SYS_LOAD_ADDR
>  #define CONFIG_FASTBOOT_BUF_SIZE       0x08000000
>
> +/* rockusb  */
> +#define CONFIG_CMD_ROCKUSB
> +#define CONFIG_USB_FUNCTION_ROCKUSB

These should go in Kconfig. I'm surprised you don't get a build error
trying to do this.

Perhaps add 'imply' lines under 'config ARCH_ROCKCHIP' ?

> +
>  /* usb mass storage */
>  #define CONFIG_USB_FUNCTION_MASS_STORAGE
>  #define CONFIG_CMD_USB_MASS_STORAGE
> --
> 1.9.1
>