[U-Boot] [PATCH 3/3] sunxi: video: Add H3/H5 TV out driver

[Maxime Ripard]

On Sun, May 14, 2017 at 09:03:19PM -0600, Simon Glass wrote:
> Hi,
> 
> On 12 May 2017 at 10:06, Maxime Ripard <maxime.ripard at free-electrons.com> wrote:
> > Hi Jernej,
> >
> > The patch content looks fine, but there's a few things that would need
> > to be addressed.
> >
> > On Wed, May 10, 2017 at 06:46:30PM +0200, Jernej Skrabec wrote:
> >> This commit adds support for TV (composite) output.
> >>
> >> Signed-off-by: Jernej Skrabec <jernej.skrabec at siol.net>
> >> ---
> >>
> >>  arch/arm/include/asm/arch-sunxi/cpu_sun4i.h |  10 ++
> >>  arch/arm/include/asm/arch-sunxi/display2.h  |  17 +++
> >>  arch/arm/include/asm/arch-sunxi/tve.h       |  17 ++-
> >>  drivers/video/sunxi/Makefile                |   2 +-
> >>  drivers/video/sunxi/sunxi_de2.c             |  60 ++++++++---
> >>  drivers/video/sunxi/sunxi_tve.c             | 156 ++++++++++++++++++++++++++++
> >>  drivers/video/sunxi/tve.c                   |   6 +-
> >
> > The difference between sunxi_tve and tve is not really obvious. What
> > about calling sunxi_tve tve-uclass, or something like that?
> 
> That name is reserved for actual uclasses.

Ok. How are the driver-part usually called?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170515/600c1f73/attachment.sig>