[U-Boot] [PATCH] sf: Fix s25fs512s erase size and remove SECT_4K flag

[Suresh Gupta]

> -----Original Message-----
> From: York Sun [mailto:york.sun at nxp.com]
> Sent: Friday, May 12, 2017 11:23 PM
> To: Suresh Gupta <suresh.gupta at nxp.com>; Jagan Teki
> <jagannadh.teki at gmail.com>
> Cc: u-boot at lists.denx.de; Jagan Teki <jagan at openedev.com>; Yao Yuan
> <yao.yuan at nxp.com>
> Subject: Re: [U-Boot] [PATCH] sf: Fix s25fs512s erase size and remove SECT_4K
> flag
> 
> On 04/27/2017 10:26 PM, Suresh Gupta wrote:
> >
> >
> >> -----Original Message-----
> >> From: York Sun [mailto:york.sun at nxp.com]
> >> Sent: Thursday, April 27, 2017 10:18 PM
> >> To: Suresh Gupta <suresh.gupta at nxp.com>; Jagan Teki
> >> <jagannadh.teki at gmail.com>
> >> Cc: u-boot at lists.denx.de; Jagan Teki <jagan at openedev.com>; Yao Yuan
> >> <yao.yuan at nxp.com>
> >> Subject: Re: [U-Boot] [PATCH] sf: Fix s25fs512s erase size and remove
> >> SECT_4K flag
> >>
> >> On 04/26/2017 10:17 PM, Suresh Gupta wrote:
> >>>
> >>>
> >>
> >> <snip>
> >>
> >>>>>
> >>>> Suresh,
> >>>>
> >>>> Did you test your patch after removing CONFIG_SPI_FLASH_BAR? Why
> >>>> doesn't this flash support BAR commands? How did it work before broken?
> >>>>
> >>>
> >>> York, the flash s25fs512s support 32 bit address to handle >16M
> >>> memory
> >> access.
> >>> With and without CONFIG_SPI_FLASH_BAR the u-boot only access up to
> >>> 16M of flash memory for this particular flash which is installed on
> >>> our boards
> >> (LS1012ARDB, LS1046ARDB, LS1088ARDB, LS2088ARDB).
> >>> So, anyhow we need to remove this CONFIG_SPI_FLASH_BAR from our
> >>> boards
> >> configs.
> >>>
> >>> For accessing >16M of flash memory (to support 32 bit address) I
> >>> already start discussion [2] with Jagan. Hopefully We have a
> >>> solution for that
> >> in near future.
> >>> [2] https://patchwork.ozlabs.org/patch/676152/
> >>>
> >>
> >> How did it (>16MB) work before?
> >>
> >> York
> >
> > According to me for this s25fs512s  particular flash,  >16M should not work in
> open source code.
> > If you have any commit id where it works, let me know.
> > I will try at my end and update you
> >
> 
> Suresh,
> 
> Where are we on this? The internal U-Boot has it working (previous SDK
> release). Did you check?
> 
> York
York,
It is working in internal U-boot which have set of patches which are not up streamed, one of which is similar to mine patch. 
Along with this, CONFIG_SPI_FLASH_BAR is disable and new flag ADDR_4B is added and couple of other changes.
All this is on our internal u-boot and never be working on open-source.
Yao send some of the patches to open source but are rejected by Jagan. 

So my intention is to make at least 16M memory access for this particular flash and then I start discussion 
with Jagan to include code to access this type of flash as we are coming with similar type of flashes in new platforms.   

Thanks
SuresH