[U-Boot] [PATCHv4 2/2] lib: move hash CONFIG options to Kconfig

Simon Glass sjg at chromium.org
Tue May 16 00:17:27 UTC 2017


On 15 May 2017 at 10:17, Tom Rini <trini at konsulko.com> wrote:
> Commit 94e3c8c4fd7b ("crypto/fsl - Add progressive hashing support
> using hardware acceleration.") created entries for CONFIG_SHA1,
> CONFIG_SHA256, CONFIG_SHA_HW_ACCEL, and CONFIG_SHA_PROG_HW_ACCEL.
> However, no defconfig has migrated to it.  Complete the move by first
> adding additional logic to various Kconfig files to select this when
> required and then use the moveconfig tool.  In many cases we can select
> these because they are required to implement other drivers.  We also
> correct how we include the various hashing algorithms in SPL.
>
> This commit was generated as follows (after Kconfig additions):
>
> [1] tools/moveconfig.py -y SHA1 SHA256 SHA_HW_ACCEL
> [2] tools/moveconfig.py -y SHA_PROG_HW_ACCEL
>
> Note:
> We cannot move SHA_HW_ACCEL and SHA_PROG_HW_ACCEL simultaneously
> because there is dependency between them.
>
> Cc: Poonam Aggrwal <poonam.aggrwal at freescale.com>
> Cc: Naveen Burmi <NaveenBurmi at freescale.com>
> Cc: Po Liu <po.liu at freescale.com>
> Cc: Shengzhou Liu <Shengzhou.Liu at freescale.com>
> Cc: Priyanka Jain <Priyanka.Jain at freescale.com>
> Cc: Shaohui Xie <Shaohui.Xie at freescale.com>
> Cc: Chunhe Lan <Chunhe.Lan at freescale.com>
> Cc: Chander Kashyap <k.chander at samsung.com>
> Cc: Steve Rae <steve.rae at raedomain.com>
> Cc: Dirk Eibach <eibach at gdsys.de>
> Cc: Feng Li <feng.li_2 at nxp.com>
> Cc: Alison Wang <alison.wang at freescale.com>
> Cc: Sumit Garg <sumit.garg at nxp.com>
> Cc: Mingkai Hu <Mingkai.Hu at freescale.com>
> Cc: York Sun <york.sun at nxp.com>
> Cc: Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>
> Cc: Jaehoon Chung <jh80.chung at samsung.com>
> Cc: Akshay Saraswat <akshay.s at samsung.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Heiko Schocher <hs at denx.de>
> Cc: Jagan Teki <jagan at amarulasolutions.com>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
> Changes in v4:
> - Clean up README as well
> - Re-sync defconfig changes (much less this time).
> - select SHA_HW_ACCEL on ARCH_EXYNOS5.
> Changes in v3:
> - Take authorship, update commit message more to reflect how the
>   migration happened.
> Changes in v2:
> - Add a large number of select statements so that our overall delta
>   is fairly small.  This is not size neutral but is I believe correct.
>   We had a number of cases before where we did not enable hw assist in
>   the hash command and only made use of it in certain back end locations.
>

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list