[U-Boot] [PATCH v2 6/7] rockchip: rk3368: Add initial support for RK3368 based GeekBox

[Andy Yan]

Hi:


On 2017年05月15日 21:23, Andreas Färber wrote:
> Am 15.05.2017 um 11:54 schrieb Andy Yan:
>> From: Andreas Färber <afaerber at suse.de>
>>
>> The GeekBox is a TV box from GeekBuying, based on an MXM3 module.
>> The module can be used with base boards such as the GeekBox Landingship.
>> This adds basic support to chain-load U-Boot from Rockchip's miniloader.
>>
>> Signed-off-by: Andreas Färber <afaerber at suse.de>
>> Signed-off-by: Andy Yan <andy.yan at rock-chips.com>
>> ---
>>
>> Changes in v2: None
> Still no README?

     I already added a README in this patch, but forgot to mention it in
   the changes log.
> I just confirmed that my original patchset had a separate commit for the
> .dts import, and then a big commit that added one line to it. You've
> squashed that into this single commit, and you fail to mention where the
> .dts comes from (e.g., v4.11?). It would be nice to have some "[...]"
> comment before your Signed-off-by that details which changes you made in
> my name here.
>
> Also, if my clock-frequency(?) line is still hidden in there, I believe
> that should be handled via some external -uboot.dtsi file by now?

     I keep all your dts file unmodified here.
>
> Regards,
> Andreas
>